Private hosts entries display incorrectly on Linux

This issue was migrated from bug 795 in our old bug tracker.

Original bug information:

Reporter: Ste…@‍inl…
Status: RESOLVED FIXED
Product: Wireshark
Component: GTK+ UI
OS: Linux
Platform: x86
Version: 0.10.14 or older

Attachments:

: Screenshot of display problem
hosts.zip: Zipped hosts file with CRLF newlines

Ste…@‍inl… said:

Build information: In both, the release version:

ethereal 0.10.14

Copyright 1998-2005 Gerald Combs <gerald@‍ethereal.com>. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.6.10, with GLib 2.6.6, with libpcap 0.8.3, with libz 1.2.2.2, with libpcre 5.0, with Net-SNMP 5.2.1.2, without ADNS.

Running with libpcap version 0.8.3 on Linux 2.6.15-1.1833_FC4smp.

and the latest repository version: ethereal 0.10.14 (SVN Rev 17501)

Copyright 1998-2006 Gerald Combs <gerald@‍ethereal.com> and contributors. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.6.10, with GLib 2.6.6, with libpcap 0.8.3, with libz 1.2.2.2, without libpcre, without UCD-SNMP or Net-SNMP, without ADNS, without Lua. NOTE: this build doesn't support the "matches" operator for Ethereal filter syntax.

Running with libpcap version 0.8.3 on Linux 2.6.15-1.1833_FC4smp.

Entries in the $HOME/.ethereal/hosts file do not display correctly in the packet
list. The text is shifted up about 1/2 line as shown in the forthcoming attachment.

Entries in the /etc/hosts file do not exhibit this problem.

This happens on Linux in the release 0.10.14 version as well as the latest
repository version, but does NOT happen on Windows, at least not in the release
0.10.14 version.

added oslinux uigtk version0.x labels

Ste…@‍inl… said:

Created attachment 217 Screenshot of display problem

Ulf Lamping said:

?!? I don't know *any* reason which might cause this problem ?!? It sounds very,
very strange to me ...

The code doing the address resolution is isolated from the code displaying the
values, so I don't see any reason why it should make a difference where the
address is coming from.

What happens, if you Refresh the screen after stopping a capture. Does the
problem remain?

Ste…@‍inl… said:

(In reply to comment #2)  

Leave it to me to find something like this :-)

Refreshing does not change the display.

Guy Harris said:

Perhaps the code to read the user's personal hosts file is putting bogus bytes into the host name (e.g., by not properly null-terminating strings, or something such as that), and GTK+ is messing up the display when it tries to display them.

Hosts in /etc/hosts come from gethostbyaddr(), which probably doesn't do that.

Ste…@‍inl… said:

The $‍HOME/.ethereal/hosts file had been copied from a Windows box and had CRLF newlines. Correcting the format removed the issue, however you might still consider stripping configuration files of bogus characters... or not.

Ulf Lamping said:

Hmmm, I'm usually the one getting pissed on people reopen bugs, but that's really a one that's to be fixed.

Even an invalid hosts file shouldn't do any harm on the display ...

Could you attach a zipped (this will keep CRNL things) hosts file showing this problem?

Ste…@‍inl… said:

Created attachment 218 Zipped hosts file with CRLF newlines

Any hosts copied from Windows ought to show the problem, as well as any saved with Nedit using the DOS format. But, since you asked...

Jaap Keuter said:

Fixed in revision 19075.

Bugzilla Administrator said:

Consolidate the 0.10.x release versions.

closed