Bug 11827 - Wireshark heap-based out-of-bounds read in infer_pkt_encap
Summary: Wireshark heap-based out-of-bounds read in infer_pkt_encap
Status: RESOLVED FIXED
Alias: None
Product: Wireshark
Classification: Unclassified
Component: Capture file support (libwiretap) (show other bugs)
Version: Git
Hardware: All All
: Low Major (vote)
Target Milestone: ---
Assignee: Bugzilla Administrator
URL:
Depends on:
Blocks:
 
Reported: 2015-11-30 15:54 UTC by Mateusz Jurczyk
Modified: 2016-09-28 20:14 UTC (History)
1 user (show)

See Also:


Attachments
Reproducers. (954 bytes, application/zip)
2015-11-30 15:54 UTC, Mateusz Jurczyk
Details
First capture from the zipball (131 bytes, application/octet-stream)
2015-12-20 16:29 UTC, Martin Kaiser
Details
Second capture from the zipball (104 bytes, application/octet-stream)
2016-09-28 20:13 UTC, Guy Harris
Details
Third capture from the zipball (216 bytes, application/octet-stream)
2016-09-28 20:14 UTC, Guy Harris
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Jurczyk 2015-11-30 15:54:24 UTC
Created attachment 14087 [details]
Reproducers.

Build Information:
Wireshark git master.
--
The following crash due to a heap-based out-of-bounds read can be observed in an ASAN build of Wireshark (current git master), by feeding a malformed file to tshark ("$ ./tshark -nVxr /path/to/file"):

Attached are three files which trigger the crash.

--- cut ---
==6473==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61b00001335c at pc 0x7f391e585d1e bp 0x7ffc0ff625c0 sp 0x7ffc0ff625b8
READ of size 1 at 0x61b00001335c thread T0
    #0 0x7f391e585d1d in infer_pkt_encap wireshark/wiretap/ngsniffer.c:1767:27
    #1 0x7f391e582ac7 in fix_pseudo_header wireshark/wiretap/ngsniffer.c:1805:11
    #2 0x7f391e57d07e in ngsniffer_process_record wireshark/wiretap/ngsniffer.c:1299:20
    #3 0x7f391e576418 in ngsniffer_read wireshark/wiretap/ngsniffer.c:1034:9
    #4 0x7f391e62429b in wtap_read wireshark/wiretap/wtap.c:1309:7
    #5 0x51f7ea in load_cap_file wireshark/tshark.c:3479:12
    #6 0x515daf in main wireshark/tshark.c:2197:13

0x61b00001335c is located 0 bytes to the right of 1500-byte region [0x61b000012d80,0x61b00001335c)
allocated by thread T0 here:
    #0 0x4c0bc8 in malloc llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:40
    #1 0x7f390a251610 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x4e610)
    #2 0x7f391e48d0e5 in wtap_open_offline wireshark/wiretap/file_access.c:1105:2
    #3 0x51bd1d in cf_open wireshark/tshark.c:4195:9
    #4 0x51584e in main wireshark/tshark.c:2188:9

SUMMARY: AddressSanitizer: heap-buffer-overflow wireshark/wiretap/ngsniffer.c:1767:27 in infer_pkt_encap
Shadow bytes around the buggy address:
  0x0c367fffa610: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c367fffa620: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c367fffa630: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c367fffa640: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c367fffa650: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0c367fffa660: 00 00 00 00 00 00 00 00 00 00 00[04]fa fa fa fa
  0x0c367fffa670: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c367fffa680: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0c367fffa690: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c367fffa6a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0c367fffa6b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07 
  Heap left redzone:       fa
  Heap right redzone:      fb
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack partial redzone:   f4
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==6473==ABORTING
--- cut ---

This bug is subject to a 90 day disclosure deadline. If 90 days elapse without a broadly available patch, then the bug report will automatically become visible to the public.
Comment 1 Martin Kaiser 2015-12-20 16:28:42 UTC
https://code.wireshark.org/review/#/c/12750/
Comment 2 Martin Kaiser 2015-12-20 16:29:46 UTC
Created attachment 14165 [details]
First capture from the zipball
Comment 3 Michael Mann 2015-12-20 21:41:56 UTC
Making public for Gerrit hooks
Comment 4 Gerrit Code Review 2015-12-20 23:19:04 UTC
Change 12756 had a related patch set uploaded by Guy Harris:
Add bounds checks and fix a length argument.

https://code.wireshark.org/review/12756
Comment 5 Gerrit Code Review 2015-12-20 23:19:25 UTC
Change 12756 merged by Guy Harris:
Add bounds checks and fix a length argument.

https://code.wireshark.org/review/12756
Comment 6 Gerrit Code Review 2015-12-20 23:19:34 UTC
Change 12757 had a related patch set uploaded by Guy Harris:
Add bounds checks and fix a length argument.

https://code.wireshark.org/review/12757
Comment 7 Gerrit Code Review 2015-12-20 23:19:41 UTC
Change 12757 merged by Guy Harris:
Add bounds checks and fix a length argument.

https://code.wireshark.org/review/12757
Comment 8 Gerrit Code Review 2015-12-20 23:19:53 UTC
Change 12758 had a related patch set uploaded by Guy Harris:
Add bounds checks and fix a length argument.

https://code.wireshark.org/review/12758
Comment 9 Gerrit Code Review 2015-12-20 23:20:00 UTC
Change 12758 merged by Guy Harris:
Add bounds checks and fix a length argument.

https://code.wireshark.org/review/12758
Comment 10 Gerrit Code Review 2016-02-05 20:46:53 UTC
Change 13774 had a related patch set uploaded by Balint Reczey:
Add bounds checks and fix a length argument.

https://code.wireshark.org/review/13774
Comment 11 Gerrit Code Review 2016-02-05 20:47:01 UTC
Change 13774 merged by Balint Reczey:
Add bounds checks and fix a length argument.

https://code.wireshark.org/review/13774
Comment 12 Guy Harris 2016-09-28 20:13:50 UTC
Created attachment 14962 [details]
Second capture from the zipball
Comment 13 Guy Harris 2016-09-28 20:14:40 UTC
Created attachment 14963 [details]
Third capture from the zipball