prevent linking against your older installed libraries

This issue was migrated from bug 10788 in our old bug tracker.

Original bug information:

Reporter: Jeroen Roovers
Status: RESOLVED FIXED
Product: Wireshark
Component: Build process
OS: Gentoo
Platform: All
Version: 1.99.x (Experimental)

Attachments:

wireshark-1.6.13-ldflags.patch: Patch to prevent linking against your older installed libraries

Jeroen Roovers said:

Created attachment 13331 Patch to prevent linking against your older installed libraries

Build Information: TShark (Wireshark) 1.99.1 (Git Rev Unknown from unknown)

Copyright 1998-2014 Gerald Combs <gerald@‍wireshark.org> and contributors. License GPLv2+: GNU GPL version 2 or later <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html> This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with libpcap, with POSIX capabilities (Linux), with libnl 3, with libz 1.2.8, with GLib 2.40.0, with SMI 0.4.8, with c-ares 1.10.0, with Lua 5.1, with GnuTLS 3.3.10, with Gcrypt 1.5.4, with MIT Kerberos, with GeoIP.

Running on Linux 3.18.0-gentoo-JeR, with locale en_GB.utf8, with libpcap version 1.6.2, with libz 1.2.8, with GnuTLS 3.3.10, with Gcrypt 1.5.4. Intel(R) Core(TM)2 Duo CPU E8400 @ 3.00GHz

Built using gcc 4.8.3.

AC_WIRESHARK_ADD_DASH_L adds -L<libdir> which means it might link against an older installed wireshark's libraries. Generally the linker should already know to find <libdir> so do not add it here. Gentoo has been carrying this patch for a long time (as the version in the filename might point out) but I don't see how it wouldn't carry over to other distributions or indeed platforms.

added build oslinux versiondev labels

Alexis La Goutte said:

Hi,

It is possible to push your patch on Gerrit ?

Alexis La Goutte said:

If you need help about Gerrit : http://wiki.wireshark.org/Development/SubmittingPatches

Alexis La Goutte said:

Hi Jeroen,

Do you have some problem to push the patch on Gerrit ?

Evan Huus said:

No response from OP, but the patch is small enough somebody else could push it to gerrit

Mike Frysinger said:

hmm, the generalization is fine, but i'm not sure in this particular case it applies.  in looking at the current git, every use of AC_WIRESHARK_ADD_DASH_L looks OK.

acinclude.m4 has 3 users, but each one does:
AC_DEFUN([AC_WIRESHARK_PCAP_CHECK], [
  ...
  AC_WIRESHARK_PUSH_FLAGS
  ...
  CPPFLAGS="$CPPFLAGS -I$pcap_dir/include"
  AC_WIRESHARK_ADD_DASH_L(LDFLAGS, $pcap_dir/lib)
  ...
  AC_WIRESHARK_POP_FLAGS
  ...
])
so the -L flag is being set to an explicit path (coming mostly from the user), testing for a system lib, and then popped, so it won't pollute the build.

configure.ac has 5 users, but each one is directly added due to the user passing an explicit path that they want like:
AC_ARG_WITH(ssl,
...
if test "x$withval" = "xno";  then
    want_ssl=no
elif test "x$withval" = "xyes"; then
    want_ssl=yes
elif test -d "$withval"; then
    want_ssl=yes
    AC_WIRESHARK_ADD_DASH_L(WS_LDFLAGS, ${withval}/lib)
fi
...
so the yes & no flags are correctly respected, and the explicit path option is used only when configured that way.

do you have an exact scenario that still applies ?  i would believe there being problems with the build over a year ago that has been fixed since ...

João Valverde said:

I agree with Mike. There have been some change to the build, I don't think this applies any longer.

And the attached patch is fine for a distribution but it is not acceptable for mainline IMO.

Reopen if necessary with more details, I'm very interested in fixing this if it is still a problem.

Marking fixed since it was confirmed.

closed