Packet byte pane in Qt version of packet window isn't being displayed

This issue was migrated from bug 11760 in our old bug tracker.

Original bug information:

Reporter: jla…@‍sla…
Status: RESOLVED FIXED
Product: Wireshark
Component: Qt UI
OS: All
Platform: All
Version: 2.0.0

See also: Issue #14478 (closed)

jla…@‍sla… said:

Build Information: Version 2.0.0 (v2.0.0-0-g9a73b827 from master-2.0)

Copyright 1998-2015 Gerald Combs <gerald@‍wireshark.org> and contributors. License GPLv2+: GNU GPL version 2 or later <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html> This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.3.2, with WinPcap (4_1_3), with libz 1.2.8, with GLib 2.42.0, with SMI 0.4.8, with c-ares 1.9.1, with Lua 5.2, with GnuTLS 3.2.15, with Gcrypt 1.6.2, with MIT Kerberos, with GeoIP, with QtMultimedia, with AirPcap.

Running on 64-bit Windows 7 Service Pack 1, build 7601, with locale C, with WinPcap version 4.1.3 (packet.dll version 4.1.0.2980), based on libpcap version 1.0 branch 1_0_rel0b (20091008), with GnuTLS 3.2.15, with Gcrypt 1.6.2, without AirPcap. Intel(R) Core(TM) i3-3240 CPU @ 3.40GHz (with SSE4.2), with 8094MB of physical memory.

Built using Microsoft Visual C++ 12.0 build 31101

Wireshark is Open Source Software released under the GNU General Public License.

Check the man page and http://www.wireshark.org for more information.

Topic says it...GTK interface shows packet bytes in the separate window (when you double-click a packet in the packet list), the new QT does not.  Can we get this implemented?  Thank you.

added uiqt version2.0 labels

Guy Harris said:

Yes, the Qt version of the packet window doesn't have a packet bytes pane. It should.

Guy Harris said:

This is a regression in functionality, so raising the priority.

Guy Harris said:

There's code in ui/qt/packet_dialog.cpp to create a new byte view, but somehow it's not working.

jla…@‍sla… said:

Thanks for looking into this...please let me know if there's anything else I can provide.

Gerrit Code Review said:

Change 14713 had a related patch set uploaded by Peter Wu: Fix byte pane not showing up in Packet dialog

https://code.wireshark.org/review/14713

Gerrit Code Review said:

Change 14713 merged by Alexis La Goutte: Fix byte pane not showing up in Packet dialog

https://code.wireshark.org/review/14713

Gerrit Code Review said:

Change 14722 had a related patch set uploaded by Alexis La Goutte: Fix byte pane not showing up in Packet dialog

https://code.wireshark.org/review/14722

Gerrit Code Review said:

Change 14722 merged by Alexis La Goutte: Fix byte pane not showing up in Packet dialog

https://code.wireshark.org/review/14722

name said:

Still not seeing the pane in 2.4.4. Is this a regression?

>  

Version 2.4.4 (Git v2.4.4 packaged as 2.4.4-1~16.04.0)

Copyright 1998-2018 Gerald Combs <gerald@wireshark.org> and contributors.
License GPLv2+: GNU GPL version 2 or later <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html>
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.5.1, with libpcap, with POSIX capabilities (Linux),
with libnl 3, with GLib 2.48.2, with zlib 1.2.8, with SMI 0.4.8, with c-ares
1.10.0, with Lua 5.2.4, with GnuTLS 3.4.10, with Gcrypt 1.6.5, with MIT
Kerberos, with GeoIP, with nghttp2 1.7.1, with LZ4, with Snappy, with libxml2
2.9.3, with QtMultimedia, without AirPcap, with SBC, with SpanDSP.

Running on Linux 4.13.0-26-generic, with Intel(R) Pentium(R) CPU G3258 @ 3.20GHz
(with SSE4.2), with 32006 MB of physical memory, with locale en_US.UTF-8, with
libpcap version 1.7.4, with GnuTLS 3.4.10, with Gcrypt 1.6.5, with zlib 1.2.8.

Built using gcc 5.4.0 20160609.

Peter Wu said:

(In reply to name from comment #‍9)
> Still not seeing the pane in 2.4.4. Is this a regression?

Your byte view window is likely hidden by making it very small. Click on the border between the status bar and the packet details view and drag up.

wir…@‍noh… said:

Indeed that's the problem. Thanks.

closed

mentioned in issue #14478 (closed)