PIM: pim.group filter have the same name for IPv4 and IPv6

This issue was migrated from bug 12061 in our old bug tracker.

Original bug information:

Reporter: athu
Status: RESOLVED FIXED
Product: Wireshark
Component: Common utilities (libwsutil)
OS: Windows 7
Platform: x86
Version: 2.0.1

Attachments:

pim.pcap: pim join pcap
: 1.12.9 filter with pim.group
: 2.0.1 filter with pim.group
: filter with pim.group_address

athu said:

Build Information: Version 2.0.1 (v2.0.1-0-g59ea380c from master-2.0)

Copyright 1998-2015 Gerald Combs <gerald@‍wireshark.org> and contributors. License GPLv2+: GNU GPL version 2 or later <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html> This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with Qt 5.3.2, with WinPcap (4_1_3), with libz 1.2.8, with GLib 2.38.0, with SMI 0.4.8, with c-ares 1.9.1, with Lua 5.2, with GnuTLS 3.2.15, with Gcrypt 1.6.2, with MIT Kerberos, with GeoIP, with QtMultimedia, with AirPcap.

Running on 64-bit Windows 7 Service Pack 1, build 7601, with locale C, with WinPcap version 4.1.3 (packet.dll version 4.1.0.2980), based on libpcap version 1.0 branch 1_0_rel0b (20091008), with GnuTLS 3.2.15, with Gcrypt 1.6.2, with AirPcap 4.1.1 build 1838. Intel(R) Core(TM) i5-4300M CPU @ 2.60GHz (with SSE4.2), with 7879MB of physical memory.

Built using Microsoft Visual C++ 12.0 build 31101

Wireshark is Open Source Software released under the GNU General Public License.

Check the man page and http://www.wireshark.org for more information.

In old release, i.e. 1.8.2, I was able to filter pim.group in pim.join packet. But in 2.0.1, seems filter pim.group had been removed, hence I use pim.group_address but unable to filter any packet.

added libwsutil oswindows version2.0 labels

Alexis La Goutte said:

Hi,

Can you attach a pcap sample for try ?

Pascal Quantin said:

Hi,

pim.group filter still exists in 2.0.1 (it was not present in 1.8.2) but seems buggy: the same filter name is used both for IPv4 and IPv6 addresses, which is not correct. Could you attach a sample capture demonstrating the issue?

athu said:

Created attachment 14290 pim join pcap

athu said:

Created attachment 14291 1.12.9 filter with pim.group

athu said:

Created attachment 14292 2.0.1 filter with pim.group

athu said:

Created attachment 14293 filter with pim.group_address

Pascal Quantin said:

Thanks, your capture confirms that the pim.group and pim.group_address filters fail because they have the same name for 2 incompatible address type Ipv4 and IPv6. Which should probably replace pim.group and pim.group_ipv4 and pim.group_ipv6.

Alexis La Goutte said:

(In reply to Pascal Quantin from comment #‍7)
> Thanks, your capture confirms that the pim.group and pim.group_address
> filters fail because they have the same name for 2 incompatible address type
> Ipv4 and IPv6.
> Which should probably replace pim.group and pim.group_ipv4 and
> pim.group_ipv6.

There is some other field too... (may be quick pim_group for ipv4 and set pim.group_ipv6 for IPv6)

There is no code for check this ?

Pascal Quantin said:

(In reply to Alexis La Goutte from comment #8)  
> (In reply to Pascal Quantin from comment #7)  
> > Thanks, your capture confirms that the pim.group and pim.group_address  
> > filters fail because they have the same name for 2 incompatible address type  
> > Ipv4 and IPv6.  
> > Which should probably replace pim.group and pim.group_ipv4 and  
> > pim.group_ipv6.  
>  
> There is some other field too... (may be quick pim_group for ipv4 and set  
> pim.group_ipv6 for IPv6)  
>  
> There is no code for check this ?  

it's under #if 0.

Alexis La Goutte said:

(In reply to Pascal Quantin from comment #9)  
> (In reply to Alexis La Goutte from comment #8)  
> > (In reply to Pascal Quantin from comment #7)  
> > > Thanks, your capture confirms that the pim.group and pim.group_address  
> > > filters fail because they have the same name for 2 incompatible address type  
> > > Ipv4 and IPv6.  
> > > Which should probably replace pim.group and pim.group_ipv4 and  
> > > pim.group_ipv6.  
> >  
> > There is some other field too... (may be quick pim_group for ipv4 and set  
> > pim.group_ipv6 for IPv6)  
> >  
> > There is no code for check this ?  
>  
> it's under #if 0.  

why ? to slow ?

Pascal Quantin said:

(In reply to Alexis La Goutte from comment #10)  
> (In reply to Pascal Quantin from comment #9)  
> > (In reply to Alexis La Goutte from comment #8)  
> > > (In reply to Pascal Quantin from comment #7)  
> > > > Thanks, your capture confirms that the pim.group and pim.group_address  
> > > > filters fail because they have the same name for 2 incompatible address type  
> > > > Ipv4 and IPv6.  
> > > > Which should probably replace pim.group and pim.group_ipv4 and  
> > > > pim.group_ipv6.  
> > >  
> > > There is some other field too... (may be quick pim_group for ipv4 and set  
> > > pim.group_ipv6 for IPv6)  
> > >  
> > > There is no code for check this ?  
> >  
> > it's under #if 0.  
>  
> why ? to slow ?  

Yes, and we have issues with ASN.1 auto generated code.

Pascal Quantin said:

In fact the code was not committed under #‍if 0 as I thought (I was just keeping it locally). The (not updated) patch can be found in bug #2402: https://bugs.wireshark.org/bugzilla/attachment.cgi?id=8654

Gerrit Code Review said:

Change 13640 had a related patch set uploaded by Pascal Quantin: PIM: fix IPv4/IPv6 filters using the same name for different address type

https://code.wireshark.org/review/13640

Gerrit Code Review said:

Change 13640 merged by Alexis La Goutte: PIM: fix IPv4/IPv6 filters using the same name for different address type

https://code.wireshark.org/review/13640

Gerrit Code Review said:

Change 13643 had a related patch set uploaded by Pascal Quantin: PIM: fix IPv4/IPv6 filters using the same name for different address type

https://code.wireshark.org/review/13643

Gerrit Code Review said:

Change 13643 merged by Pascal Quantin: PIM: fix IPv4/IPv6 filters using the same name for different address type

https://code.wireshark.org/review/13643

closed