i386 builds under Ubuntu 14.04 fail, due to signed/unsigned problem

This issue was migrated from bug 12824 in our old bug tracker.

Original bug information:

Reporter: Thomas Dreibholz
Status: RESOLVED FIXED
Product: Wireshark
Component: Build process
OS: All
Platform: x86
Version: Git

Attachments:

wireshark-c90.patch: A patch fixing the issue

Thomas Dreibholz said:

Created attachment 14879 A patch fixing the issue

Build Information: Wireshark 2.3.0 (Git Rev Unknown from unknown)

Copyright 1998-2016 Gerald Combs <gerald@‍wireshark.org> and contributors. License GPLv2+: GNU GPL version 2 or later <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html> This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.2.1, with libpcap, with POSIX capabilities (Linux), with libnl 3, with GLib 2.40.2, with zlib 1.2.8, with SMI 0.4.8, with c-ares 1.10.0, with Lua 5.2.3, with GnuTLS 3.2.11, with Gcrypt 1.5.3, with MIT Kerberos, with GeoIP, with QtMultimedia, without AirPcap.

Running on Linux 4.4.0-34-generic, with locale nb_NO.UTF-8, with libpcap version 1.5.3, with GnuTLS 3.2.11, with Gcrypt 1.5.3, with zlib 1.2.8. Intel(R) Xeon(R) CPU E5-1650 0 @ 3.20GHz (with SSE4.2)

Built using gcc 4.8.4.

i386 builds for Ubuntu 14.04 fail with hundreds of errors "this decimal constant is unsigned only in ISO C90", all at windows-common.c:119.

Warning: this decimal constant is unsigned only in ISO C90

/«BUILDDIR»/wireshark-2.3.0+git20160829074834~09be4636/epan/dissectors/packet-windows-common.c:119:1: error: this decimal constant is unsigned only in ISO C90 [-Werror]
/«BUILDDIR»/wireshark-2.3.0+git20160829074834~09be4636/epan/dissectors/packet-windows-common.c:119:1: error: this decimal constant is unsigned only in ISO C90 [-Werror]
/«BUILDDIR»/wireshark-2.3.0+git20160829074834~09be4636/epan/dissectors/packet-windows-common.c:119:1: error: this decimal constant is unsigned only in ISO C90 [-Werror]
/«BUILDDIR»/wireshark-2.3.0+git20160829074834~09be4636/epan/dissectors/packet-windows-common.c:119:1: error: this decimal constant is unsigned only in ISO C90 [-Werror]
...


The attached patch fixes the issue, by explicitly declaring the constants as "unsigned".

added build versiondev labels

Alexis La Goutte said:

Hi Thomas

Please push directly the patch on Gerrit !

Gerrit Code Review said:

Change 19182 had a related patch set uploaded by Michael Mann: packet-windows-common.h: Fix "Warning: this decimal constant is unsigned only in ISO C90"

https://code.wireshark.org/review/19182

Gerrit Code Review said:

Change 19182 merged by Michael Mann: packet-windows-common.h: Fix "Warning: this decimal constant is unsigned only in ISO C90"

https://code.wireshark.org/review/19182

closed