Error received from dissect_wccp2_hash_assignment_info()

This issue was migrated from bug 14573 in our old bug tracker.

Original bug information:

Reporter: ych…@‍tru…
Status: RESOLVED FIXED
Product: Wireshark
Component: Dissection engine (libwireshark)
OS: Linux
Platform: x86
Version: unspecified

Attachments:

wccp_Alternate_Assignment_fix_git.patch: patch
output_AAC_before_patch.txt: output before patch
output_AAC_after_patch.txt: output after patch
wccpGREandMASK.pcap: pcap
wccpGREandMASK.pcap: pcap

ych…@‍tru… said:

Created attachment 16236 patch

Build Information: ./tshark -v TShark (Wireshark) 2.4.5 (v2.4.5)

Copyright 1998-2018 Gerald Combs <gerald@‍wireshark.org> and contributors. License GPLv2+: GNU GPL version 2 or later <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html> This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with libpcap, without POSIX capabilities, without libnl, with GLib 2.54.3, with zlib 1.2.8, without SMI, without c-ares, without Lua, without GnuTLS, with Gcrypt 1.8.1, without Kerberos, without GeoIP, without nghttp2, without LZ4, without Snappy, without libxml2.

Running on Linux 4.15.12, with Intel(R) Core(TM) i7-2640M CPU @ 2.80GHz (with SSE4.2), with 7931 MB of physical memory, with locale en_US.UTF-8, with libpcap version 1.8.1, with Gcrypt 1.8.1, with zlib 1.2.8.

Built using gcc 7.3.0.

 Error received when dissect Alternate Assignment Component:

[Dissector bug, protocol WCCP: field wccp.cache_ip is not of type FT_CHAR, FT_UINT8, FT_UINT16, FT_UINT24, FT_UINT32, or FT_FRAMENUM]
    [Expert Info (Error/Malformed): field wccp.cache_ip is not of type FT_CHAR, FT_UINT8, FT_UINT16, FT_UINT24, FT_UINT32, or FT_FRAMENUM]
        [field wccp.cache_ip is not of type FT_CHAR, FT_UINT8, FT_UINT16, FT_UINT24, FT_UINT32, or FT_FRAMENUM]
        [Severity level: Error]
        [Group: Malformed]


Used function proto_tree_add_uint_format() for ipv4 instead of
proto_tree_add_ipv4_format

added libwireshark oslinux labels

ych…@‍tru… said:

Created attachment 16237 output before patch

ych…@‍tru… said:

Created attachment 16238 output after patch

ych…@‍tru… said:

Created attachment 16239 pcap

ych…@‍tru… said:

Created attachment 16240 pcap

ych…@‍tru… said:

patch will be pushed to Gerrit

Gerrit Code Review said:

Change 26661 merged by Anders Broman: WCCP: use proto_tree_add_ipv4_format() if ipv4 used

https://code.wireshark.org/review/26661

Gerrit Code Review said:

Change 28716 had a related patch set uploaded by Guy Harris: WCCP: use proto_tree_add_ipv4_format() if ipv4 used

https://code.wireshark.org/review/28716

Gerrit Code Review said:

Change 28716 merged by Guy Harris: WCCP: use proto_tree_add_ipv4_format() if ipv4 used

https://code.wireshark.org/review/28716

Gerrit Code Review said:

Change 28717 had a related patch set uploaded by Guy Harris: WCCP: use proto_tree_add_ipv4_format() if ipv4 used

https://code.wireshark.org/review/28717

Gerrit Code Review said:

Change 28717 merged by Guy Harris: WCCP: use proto_tree_add_ipv4_format() if ipv4 used

https://code.wireshark.org/review/28717

Gerrit Code Review said:

Change 28718 had a related patch set uploaded by Guy Harris: WCCP: use proto_tree_add_ipv4_format() if ipv4 used

https://code.wireshark.org/review/28718

Gerrit Code Review said:

Change 28718 merged by Guy Harris: WCCP: use proto_tree_add_ipv4_format() if ipv4 used

https://code.wireshark.org/review/28718

closed