Bacnet(app): fix wrong value for id 183 (logging-device -> logging-object)

This issue was migrated from bug 15767 in our old bug tracker.

Original bug information:

Reporter: kit…@‍m-s…
Status: RESOLVED FIXED
Product: Wireshark
Component: Dissection engine (libwireshark)
OS: Windows 10
Platform: x86-64
Version: 2.6.1

Attachments:

AC-2001_mstp.pcapng: No.2910 is property identifier 183

kit…@‍m-s… said:

Build Information:

Version 3.0.1 (v3.0.1-0-gea351cd8)

Copyright 1998-2019 Gerald Combs <gerald@‍wireshark.org> and contributors. License GPLv2+: GNU GPL version 2 or later <http://www.gnu.org/licenses/old-licenses/gpl-2.0.html> This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with Qt 5.12.1, with WinPcap SDK (WpdPack) 4.1.2, with GLib 2.52.2, with zlib 1.2.11, with SMI 0.4.8, with c-ares 1.14.0, with Lua 5.2.4, with GnuTLS 3.6.3 and PKCS #‍11 support, with Gcrypt 1.8.3, with MIT Kerberos, with MaxMind DB resolver, with nghttp2 1.14.0, with LZ4, with Snappy, with libxml2 2.9.9, with QtMultimedia, with AirPcap, with SBC, with SpanDSP, with bcg729.

Running on 64-bit Windows 10 (1803), build 17134, with Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (with SSE4.2), with 8099 MB of physical memory, with locale Japanese_Japan.932, with WinPcap version 4.1.3 (packet.dll version 4.1.0.2980), based on libpcap version 1.0 branch 1_0_rel0b (20091008), with GnuTLS 3.6.3, with Gcrypt 1.8.3, without AirPcap, binary plugins supported (14 loaded). Built using Microsoft Visual Studio 2017 (VC++ 14.12, build 25835).

I am using bacnet filter.
"Property identifier 183" was displayed as "logging-device", but is it "logging-object"?

added libwireshark oswindows version2.6 labels

Alexis La Goutte said:

Hi,

can you attach a pcap with the issue ?

kit…@‍m-s… said:

Created attachment 17113 No.2910 is property identifier 183

kit…@‍m-s… said:

(In reply to Alexis La Goutte from comment #1)  
> こんにちは、  
>  
> あなたは問題でpcapを付けることができますか？  


I have attached the file in question.

Alexis La Goutte said:

(In reply to kitagaki from comment #3)  
> (In reply to Alexis La Goutte from comment #1)  
> > こんにちは、  
> >  
> > あなたは問題でpcapを付けることができますか？  
>  
>  
> I have attached the file in question.  

Thanks,

do you have a link the spec ?

kit…@‍m-s… said:

(In reply to Alexis La Goutte from comment #4)  
> （コメント＃3からkitagakiに返信）  
>  >（コメント＃1からAlexis La Goutteに返信）  
> >>こんにちは、  
> >>  
> >>あなたは問題でpcapを付けることができますか？  
> >  
> >  
> >問題のファイルを添付しました。  
>  
> ありがとう、  
>  
> あなたは仕様へのリンクを持っていますか？  

I have a book about bacnet specifications, so
I searched for the part described in the web page.
[183 logging_Object] on page 9 of link material
There is a description.


https://docsplayer.net/102248163-Bacnet%E9%80%9A%E4%BF%A1%E4%BB%95%E6%A7%98%E6%9B%B8.html

Gerrit Code Review said:

Change 33133 had a related patch set uploaded by Alexis La Goutte: bacapp: fix wrong value for id 183

https://code.wireshark.org/review/33133

Gerrit Code Review said:

Change 33133 merged by Anders Broman: bacapp: fix wrong value for id 183

https://code.wireshark.org/review/33133

Gerrit Code Review said:

Change 33135 had a related patch set uploaded by Alexis La Goutte: bacapp: fix wrong value for id 183

https://code.wireshark.org/review/33135

Gerrit Code Review said:

Change 33136 had a related patch set uploaded by Alexis La Goutte: bacapp: fix wrong value for id 183

https://code.wireshark.org/review/33136

Gerrit Code Review said:

Change 33135 merged by Anders Broman: bacapp: fix wrong value for id 183

https://code.wireshark.org/review/33135

Gerrit Code Review said:

Change 33136 merged by Anders Broman: bacapp: fix wrong value for id 183

https://code.wireshark.org/review/33136

kit…@‍m-s… said:

Thank you for the quick solution


I have never used a patch file, but how do you use it?

Gerald Combs said:

(In reply to kitagaki from comment #12)  
> Thank you for the quick solution  
>  
>  
> I have never used a patch file, but how do you use it?  

The patch file updates Wireshark's source code, so in order to use it you would have to either apply it manually or pull the latest code from our source code repository, then rebuild Wireshark. This can be a lot of work, so in order to make things more convenient we have an automated build system which builds new packages each time the source code is updated:

https://www.wireshark.org/download/automated/win64/

kit…@‍m-s… said:

Thank you

closed