Added: PW ATM 1:1, AAL5 SDU, AAL5 PDU support + BFD fix + PW ATM OAM fix

This issue was migrated from bug 3516 in our old bug tracker.

Original bug information:

Reporter: Artem Tamazov
Status: RESOLVED FIXED
Product: Wireshark
Component: GTK+ UI
OS: All
Platform: All
Version: 1.3.x (Experimental)

Attachments:

tlab-pw-atm-019-svn28661.patch: tlab-pw-atm-019-svn28661.patch
ATM_pwe3_1to1_VC_cellconc10.pcap: ATM_pwe3_1to1_VC_cellconc10.pcap
ATM_pwe3_1to1_VP_cellconc10.pcap: ATM_pwe3_1to1_VP_cellconc10.pcap
aal-sdu-switched_SMALL.pcap: aal-sdu-switched_SMALL.pcap
tlab-pw-atm-022-bfd-001-svn28880.patch: Substantial update
VC-Flapping-20090106v1_SMALL.pcap: test stream for BFD check
aal5-pdu-randrom.pcap: test for AAL5 PDE mode

Artem Tamazov said:

Build Information: TShark 1.3.0-tlab-pwe3-all (SVN 28661)

Copyright 1998-2009 Gerald Combs <gerald@‍wireshark.org> and contributors. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GLib 2.20.1, with WinPcap (version unknown), with libz 1.2.3, without POSIX capabilities, with libpcre 7.0, with SMI 0.4.8, with c-ares 1.6.0, without Lua, without Python, with GnuTLS 2.6.4, with Gcrypt 1.4.4, with MIT Kerberos, with GeoIP.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.0.2 (packet.dll version 4.0.0.1040), based on libpcap version 0.9.5, GnuTLS 2.6.4, Gcrypt 1.4.4.

Built using Microsoft Visual C++ 7.10 build 3077

* Added: PW ATM AAL5 CPCS-SDU mode support
* Added: PW ATM One-to-One mode support
  * Includes VCP/VCC mode auto-detection heuristics
* Added: OAM cell detection/decoding support for all ATM pseudowires.
* Added: Detection/colorizing of malformed PW ATM encapsulations
* Added: LLC SNAP auto-detection in ATM decoder.

Info from PW to ATM dissector is now passed via pinfo->private_data.
"pw_atm_xxx" members of packet_info are not needed anymore and thus removed.
The "atm_4717" dissector is not needed and thus removed as well.

added uigtk versiondev labels

Artem Tamazov said:

Created attachment 3092 tlab-pw-atm-019-svn28661.patch

Implementation of pw-atm-aal5-sdu and pw-atm-1-to-1 etc.

Artem Tamazov said:

Created attachment 3093 ATM_pwe3_1to1_VC_cellconc10.pcap

Sample capture for 1:1 mode testing.

Artem Tamazov said:

Created attachment 3094 ATM_pwe3_1to1_VP_cellconc10.pcap

Sample capture for 1:1 mode testing.

Artem Tamazov said:

Created attachment 3095 aal-sdu-switched_SMALL.pcap

Sample capture for AAL5 SDU mode testing.

Artem Tamazov said:

Fuzz tested, of course.

Artem Tamazov said:

Any feedback?

Anders Broman said:

Hi, The patch fails to apply cleanly for me :( Can you make a new one against HEAD? /Anders

Artem Tamazov said:

(In reply to comment #7)  
> The patch fails to apply cleanly for me :( Can you make a new one against HEAD?  

Hi Anders,

This is becuase this patch depends on bug 3397, which is not accepted yet.
At the moment 3397 is being reconsidered.
Please wait for a while...

Of course, if you want to have ATM AAL5 SDU and 1:1 support ASAP, I can prepare alternative patch which will fit to HEAD.

artem//

Artem Tamazov said:

Created attachment 3227
Substantial update

Dependence from bug# 3397 is removed.
Baseline is SVN rev.28880.

Updated patch includes the following modifications:

MPLS PW ATM dissector:
* Added: PW ATM AAL5 CPCS-SDU mode support
* Added: PW ATM One-to-One mode support
  * Includes VCP/VCC mode auto-detection heuristics
* Added: OAM cell detection/decoding support for all ATM pseudowires.
* Added: Detection/colorizing of malformed PW ATM encapsulations
* Added: LLC SNAP auto-detection in ATM decoder.
* Added: PW ATM AAL5 PDU mode support
* Added: auto-detection of OAM F4 when is VCI 3 or 4 and PT 0X0.
* Info from PW to ATM dissector is now passed via pinfo->private_data.
  "pw_atm_xxx" members of packet_info are not needed anymore and thus removed.
  The "atm_4717" dissector is not needed and thus removed as well.

MPLS PWAC dissector:
* Fixed to properly decode Channel Type 0x07 is raw BFD.
* Added preferences:
  - "Assume PWAC Channel Type 0x0 is raw BFD"
  - "Assume that all PWAC Channel Types (except 0x21) are raw BFD"
  - "As a last resort, try to decode PWAC payloads as PPP traffic"
  - New preferences are located in Edit -> Preferences -> Protocols -> MPLS

Sorry for so many modifications, but I had mo option except
too much manual work after change in bug# 3397.

Artem Tamazov said:

Created attachment 3228 test stream for BFD check

Artem Tamazov said:

*** Bug #3527 (closed) has been marked as a duplicate of this bug. ***

Artem Tamazov said:

*** Bug #3563 (closed) has been marked as a duplicate of this bug. ***

Artem Tamazov said:

Created attachment 3229 test for AAL5 PDE mode

This is not real AAL5 PDU capture, but extract some very big and errorneous capture which contains only aal5-pdu-like frames and allows to test corner cases.

Artem Tamazov said:

Everything was fuzz tested.

Anders Broman said:

Committed revision 28881. Will be included in next major release and development builds.

closed

mentioned in issue #3527 (closed)

mentioned in issue #3563 (closed)