packet-dhcpv6.c dissector error parsing ORO suboption

This issue was migrated from bug 4412 in our old bug tracker.

Original bug information:

Reporter: ale…@‍vid…
Status: RESOLVED FIXED
Product: Wireshark
Component: GTK+ UI
OS: Ubuntu
Platform: Other
Version: Git

Attachments:

: Screenshot with unrecognized suboptions
: Screenshot after fixing
packet-dhcpv6_suboptions_error.cap: dhcpv6 capture

ale…@‍vid… said:

Created attachment 4160 Screenshot with unrecognized suboptions

Build Information: Version 1.3.3 (SVN Rev 31592 from /trunk)

Copyright 1998-2010 Gerald Combs <gerald@‍wireshark.org> and contributors. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.18.3, with GLib 2.22.3, with libpcap 1.0.0, with libz 1.2.3.3, without POSIX capabilities, without libpcre, without SMI, without c-ares, without ADNS, without Lua, without Python, without GnuTLS, without Gcrypt, without Kerberos, without GeoIP, without PortAudio, without AirPcap, with new_packet_list.

Running on Linux 2.6.31-17-generic, with libpcap version 1.0.0.

Built using gcc 4.4.1.

This is similar to bug 3987. Hopefully not a duplicate.

When parsing a dhcpv6 packet, the ORO suboption (option request option) has an offset error and the rest of the cablelabs dhcpv6 suboptions are not parsed.

An error is present in the subroutine for opt_len.
in v1.2.5 the code reads
case CL_OPTION_ORO :
  field_len = 2;
  opt_len = tlv_len * field_len;
[...]

but should read
case CL_OPTION_ORO :
  field_len = 2;
  opt_len = tlv_len;
[...]

attached are before and after screenshots, and a capture.

added osubuntu uigtk versiondev labels

ale…@‍vid… said:

Created attachment 4161 Screenshot after fixing

ale…@‍vid… said:

Created attachment 4162 dhcpv6 capture

Jaap Keuter said:

Committed in revision 31609.

closed