New Protocol Submission for IEEE 1722(AVB Transport Protocol)

This issue was migrated from bug 4764 in our old bug tracker.

Original bug information:

Reporter: Torrey Atcitty
Status: RESOLVED FIXED
Product: Wireshark
Component: GTK+ UI
OS: Windows XP
Platform: x86
Version: Git

Attachments:

ieee-1722.patch: IEEE 1722 Patch
1722PacketSample.pcap: packet sample
ieee-1722V2.patch: updated patch

Torrey Atcitty said:

Build Information: Build Information: Version 1.3.6-AVB-MSRP

Copyright 1998-2010 Gerald Combs <gerald@‍wireshark.org> and contributors. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled with GTK+ 2.16.6, (32-bit) with GLib 2.22.4, with WinPcap (version unknown), with libz 1.2.3, without POSIX capabilities, without libpcre, with SMI 0.4.8, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS 2.8.5, with Gcrypt 1.4.5, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built May 11 2010), with AirPcap, with new_packet_list.

Running on Windows XP Service Pack 2, build 2600, with WinPcap version 4.1.1 (packet.dll version 4.1.0.1753), based on libpcap version 1.0 branch 1_0_rel0b (20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public License.

Check the man page and http://www.wireshark.org for more information.

New Dissector Submission for IEEE 1722 also known as the Audio Video Bridging Transport Protocol (AVBTP). Protocol is currently the primary means used to encapsulate audio and video samples for transmission across AVB networks. My company has written our own dissectors to use for testing and debugging in our own environment and this dissector is the 3rd (out of 3) that we wish to submit to the main Wireshark branch as of this moment. As such this dissector has
undergone extensive testing in the many months we have been maintaining it, but
it has also passed the fuzz testing.

added oswindows uigtk versiondev labels

Torrey Atcitty said:

Created attachment 4648 IEEE 1722 Patch

Attached patch for the new IEEE 1722 dissector. Patch should be applied on top level directory, "C:\wireshark" on my computer.

Bill Meier said:

Can you provide a sample capture ??

Bill Meier said:

Comments:

1. It appears that you could get a 'divide by 0' trap in the following
   if dbs has a garbage value in the capture file.

        dbs = tvb_get_guint8(tvb, IEEE_1722_DBS_OFFSET);

        /* Loop through all samples and add them to the audio tree. */
        for (j = 0; j < (datalen / (dbs*4)); j++) {

2. "" in hf[] "blurb" should be NULL.

3. Re:    ... = proto_register_protocol("IEEE 1722 Protocol", "IEEE1722", "1722");

   The convention appears to be to either use ieee1722 for the 'protocol-abbreviation" (and the filter names in the hf[] array).

So: what would you think about using ieee1722 or avbtp  ??

4. [There are a few tabs in the file].

Bill Meier said:

(In reply to comment #3)  
>    The convention appears to be to either use ieee1722 for the  
> 'protocol-abbreviation" (and the filter names in the hf[] array).  
>  

The above should be: "... to either use ieee1722 or a 'name' for the ..."

Torrey Atcitty said:

Created attachment 4652 packet sample

Attached a sample packet capture.

Torrey Atcitty said:

(In reply to comment #3)  
> Comments:  
> 1. It appears that you could get a 'divide by 0' trap in the following  

  Fixed.

> 2. "" in hf[] "blurb" should be NULL.  

  Done.

> 3. Re:    ... = proto_register_protocol("IEEE 1722 Protocol", "IEEE1722",  
> "1722");  

  Yeah, good idea there, those have been fixed.

> 4. [There are a few tabs in the file].  

  Ok, I think I got all of them this time.

Thanks.

Torrey Atcitty said:

Created attachment 4653 updated patch

Submitted new updated patch with fixes.

Bill Meier said:

Committed: SVN #‍32841.

Thanks !

Kok-Yong Tan said:

How is this protocol listed in Wireshark 2.6.1? I looked up IEEE-1722, AVB, AVBTP, etc., in the list of protocols in the Preferences section and don't see it listed as such. This would hugely useful for those of us in the AudioVisual space.

Pascal Quantin said:

(In reply to Kok-Yong Tan from comment #‍9)
> How is this protocol listed in Wireshark 2.6.1? I looked up IEEE-1722, AVB,
> AVBTP, etc., in the list of protocols in the Preferences section and don't
> see it listed as such. This would hugely useful for those of us in the
> AudioVisual space.

Hi,

you cannot see them in the preferences window because those dissectors do not have any preferences. Still you will see them in the supported protocols window (View -> Internals -> Supported Protocols) as they are part of Wireshark 2.6.1.

closed