Wireshark crashes if SSL preferences RSA key is actually a DSA key

This issue was migrated from bug 5662 in our old bug tracker.

Original bug information:

Reporter: Clive Nicholson
Status: RESOLVED FIXED
Product: Wireshark
Component: GTK+ UI
OS: Windows XP
Platform: Other
Version: 1.4.2

Attachments:

9ba9_appcompat.txt: Error report from the crash

Clive Nicholson said:

Created attachment 5915 Error report from the crash

Build Information: Version 1.4.2 (SVN Rev 34959 from /trunk-1.4)

Copyright 1998-2010 Gerald Combs <gerald@‍wireshark.org> and contributors. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (32-bit) with GTK+ 2.16.6, with GLib 2.22.4, with WinPcap (version unknown), with libz 1.2.3, without POSIX capabilities, without libpcre, with SMI 0.4.8, with c-ares 1.7.1, with Lua 5.1, without Python, with GnuTLS 2.8.5, with Gcrypt 1.4.5, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built Nov 18 2010), with AirPcap.

Running on Windows XP Service Pack 3, build 2600, with WinPcap version 4.1.2 (packet.dll version 4.1.0.2001), based on libpcap version 1.0 branch 1_0_rel0b (20091008), GnuTLS 2.8.5, Gcrypt 1.4.5, without AirPcap.

Built using Microsoft Visual C++ 9.0 build 30729

Wireshark is Open Source Software released under the GNU General Public License.

Check the man page and http://www.wireshark.org for more information.

When entering an RSA keys list item either without a password for a non PKCS12 key or with a password for a PKCS12 key Wireshark crashes with the following information:

AppName:wireshark.exe AppVer:1.4.2.34959 ModName:libgcrypt-11.dll
ModVer:16.5.3.1417 Offset:0004b3ff

Exception Information
Code: 0xc0000005 Flags:0x00000000 Record: 0x0000000000000000 Address:00000000003cb3ff

The debug file contains the following information:
ssl_init keys string:
157.203.50.170,443,http,u:\is01.pfx,gG1t5W1y;
ssl_init found host entry 157.203.50.170,443,http,u:\is01.pfx,gG1t5W1y
ssl_init addr '157.203.50.170' port '443' filename 'u:\is01.pfx' password(only for p12 file) 'gG1t5W1y'
4237 bytes read
PKCS#12 imported
Bag 0/0: PKCS#8 Encrypted key
Private key imported: KeyID a2:ff:02:b3:71:02:e7:06:d4:8a:4b:cc:c1:8d:10:52:...

added crash oswindows uigtk version1.4 labels

Clive Nicholson said:

Please delete this bug report. I was using a DSA key and not a RSA key'

Bill Meier said:

Marked as "Invalid" :)

Bill Meier said:

Reopening: Actually: this is a real bug. Wireshark shouldn't crash ....

Bill Meier said:

The private key import code wasn't checking that the imported private key was an RSA private key.

I've committed a fix in SVN #36174.

This fix will be queued for back-porting to the next Wireshark 1.4 release.


Thanks for the report....

closed