DACP (apple remote) enhancement to DAAP dissector

This issue was migrated from bug 5887 in our old bug tracker.

Original bug information:

Reporter: Nick Glass
Status: RESOLVED FIXED
Product: Wireshark
Component: GTK+ UI
OS: All
Platform: All
Version: Git

Attachments:

dacp.patch: dacp patch
dacp.cap: brief dacp capture
dacp2.patch: dacp patch second attempt

Nick Glass said:

Build Information:

Paste the COMPLETE build information from "Help->About Wireshark", "wireshark -v", or "tshark -v".

Attached patch adds ability to dissect DACP (apple itunes remote) tags to the DAAP protocol dissector.

Some information taken from http://dacp.jsharkey.org/ and http://code.google.com/p/tunesremote-plus/

added enhancement uigtk versiondev labels

Nick Glass said:

Created attachment 6277 dacp patch

Nick Glass said:

Created attachment 6279 brief dacp capture

short capture with playstatus, volume, user rating and album cover

Stephen Fisher said:

Thanks for your patch. Instead of calling the dissect_png() function directly, please update the patch to call it using the call_dissector() function. Putting png_handle = find_dissector("png") in the proto_reg_handoff_daap() function and then doing call_dissector(png_handle, tvb, pinfo, tree) should work. The png_handle should be a static dissector_handle_t at the top of the packet-daap.c file. Also it looks like packet-image-png.c needs to register the png dissector by name first with the register_dissector() function.

Stephen Fisher said:

Comment on attachment 6277 dacp patch

See comments

Nick Glass said:

Created attachment 6282 dacp patch second attempt

updated as per your suggestions. I was wondering about the correct method for calling one dissector from another.

Thanks

Stephen Fisher said:

Comment on attachment 6282 dacp patch second attempt

Checked in with minor revisions: remove "#‍include <stdio.h>" and change "unsigned int" to GLib's equivilent type "guint" for consistency.

Stephen Fisher said:

Committed revision 36987. Thanks for your contribution!

Stephen Fisher said:

I also added you to the AUTHORS file with the '@' in your e-mail address changed to "[AT]"

Nick Glass said:

(In reply to comment #‍8)
> I also added you to the AUTHORS file with the '@' in your e-mail address
> changed to "[AT]"

Thanks Stephen.

closed