Skip to content
Snippets Groups Projects
New look: Off

USB: unknown GET DESCRIPTOR response triggers assert failure

    • Closed Issue created by Wireshark GitLab Migration @ws-gitlab-migration

    This issue was migrated from bug 6826 in our old bug tracker.

    Original bug information:

    Reporter: Steve Magnani
    Status: RESOLVED FIXED
    Product: Wireshark
    Component: GTK+ UI
    OS: All
    Platform: All
    Version: Git

    Attachments:

    usb-unknown-descriptor.patch: Fix for the issue.

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    • Wireshark GitLab Migration
      Wireshark GitLab Migration @ws-gitlab-migration
      Author

      :speech_balloon: Steve Magnani said:

      Created attachment 7818 Fix for the issue.

      Build Information: wireshark 1.7.1 (SVN Rev 40973 from /trunk)

      Copyright 1998-2012 Gerald Combs <gerald@‍wireshark.org> and contributors. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

      Compiled (64-bit) with GTK+ 2.24.8, with Cairo 1.10.2, with Pango 1.29.4, with GLib 2.30.2, with libpcap, with libz 1.2.5, with POSIX capabilities (Linux), with SMI 0.4.8, with c-ares 1.7.4, with Lua 5.1, without Python, with GnuTLS 2.12.14, with Gcrypt 1.5.0, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built May 5 2011 11:00:51), without AirPcap.

      Running on Linux 3.2.2-1.fc16.x86_64, with locale en_US.UTF-8, with libpcap version 1.1.1, with libz 1.2.5, GnuTLS 2.12.14, Gcrypt 1.5.0.

      Built using gcc 4.6.2 20111027 (Red Hat 4.6.2-1).

      The code that handles unknown GET DESCRIPTOR responses is incorrect.
It (A) assumes that the first 4 bytes of the response are a host-endian length, and (2) tries to insert the unknown blob into the tree via a FT_BYTES item passed to proto_tree_add_uint(). The latter causes an assert failure at proto.c:2929.

To trigger the bug, comment out the USB_DT_RPIPE case in packet-usb.c:dissect_usb_setup_get_descriptor_response() and attempt to dissect a USB conversation involving a mouse.
    • Wireshark GitLab Migration added uigtk versiondev labels

      added uigtk versiondev labels

    • Wireshark GitLab Migration
      Wireshark GitLab Migration @ws-gitlab-migration
      Author

      :speech_balloon: Anders Broman said:

      Hi, Committed a slightly different solution in revision 41388. Please test and reopen the bug if not ok.

    • Wireshark GitLab Migration closed

      closed

    Please register or sign in to reply