Skip to content
Snippets Groups Projects
New look: Off

When cancelling creation of new coloring rule, old one is deleted

    • Closed Issue created by Wireshark GitLab Migration @ws-gitlab-migration

    This issue was migrated from bug 7913 in our old bug tracker.

    Original bug information:

    Reporter: chs
    Status: RESOLVED FIXED
    Product: Wireshark
    Component: GTK+ UI
    OS: OS X 10.8
    Platform: x86
    Version: 1.8.3

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently open.

    Activity

    • Wireshark GitLab Migration
      Wireshark GitLab Migration @ws-gitlab-migration ·
      Author

      💬 chs said:

      Build Information: Version 1.8.3 (SVN Rev 45256 from /trunk-1.8)

      Copyright 1998-2012 Gerald Combs <gerald@‍wireshark.org> and contributors. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

      Compiled (64-bit) with GTK+ 2.24.10, with Cairo 1.8.6, with Pango 1.30.0, with GLib 2.32.3, with libpcap, with libz 1.2.3, without POSIX capabilities, with SMI 0.4.8, without c-ares, without ADNS, with Lua 5.1, without Python, with GnuTLS 2.12.19, with Gcrypt 1.5.0, with MIT Kerberos, with GeoIP, with PortAudio V19-devel (built Aug 12 2012 22:27:54), with AirPcap.

      Running on Mac OS 10.8.2 (Darwin 12.2.0), with locale de_DE.UTF-8, with libpcap version 1.1.1, with libz 1.2.5, GnuTLS 2.12.19, Gcrypt 1.5.0, without AirPcap.

      Built using gcc 4.2.1 (Apple Inc. build 5666) (dot 3).

      Precondition:
A set of >=1 coloring rules has already been set (e.g. default rules).

Steps to reproduce:
- go to View->Coloring Rules.
- note the number of Coloring Rules (1...n).
- select "New"
- in the popup, select "Cancel".
=> Notice that at the top of the list (1), an empty rule has been inserted.
=> However, the number of Coloring rules is still the same (n)
=> At the same time, the Coloring rule at the bottom of the list (n) has been removed.

If the user were to "OK" now, he would accidentally remove a coloring rule form his set.
    • Wireshark GitLab Migration added osmacos uigtk version1.8 labels

      added osmacos uigtk version1.8 labels

    • Wireshark GitLab Migration
      Wireshark GitLab Migration @ws-gitlab-migration ·
      Author

      💬 Martin Kaiser said:

      Hi,

thanks for spotting this.

There was indeed a mistake in the handling of color filter entries. We prepended a default entry before the edit dialogue is launched and deleted the last entry when the edit was cancelled.

I fixed this in r45820. Could you have a look (and re-open the bug if you find it's not working ok)?

Regards,

   Martin
    • Wireshark GitLab Migration closed

      closed

    Please register or sign in to reply