GTK3 gtk_scrolled_window_add_with_viewport is deprecated

This issue was migrated from bug 8433 in our old bug tracker.

Original bug information:

Reporter: oja…@‍oja…
Status: RESOLVED FIXED
Product: Wireshark
Component: GTK+ UI
OS: All
Platform: x86
Version: Git

oja…@‍oja… said:

Build Information:

git-svn-id\: http\:\/\/anonsvn.wireshark.org\/wireshark\/trunk\@‍48044 f5534014-38df-0310-8fa8-9805f1628bb7





http://developer.gnome.org/gtk3/unstable/GtkScrolledWindow.html#gtk-scrolled-window-add-with-viewport
>gtk_scrolled_window_add_with_viewport has been deprecated since version 3.8 and should not be used in newly-written code. gtk_container_add() will now automatically add a GtkViewport if the child doesn't implement GtkScrollable.  


On gtk+-3.7.10 I've got:

capture_if_dlg.c: In function ‘capture_if_refresh_if_list’:
capture_if_dlg.c:671:3: error: ‘gtk_scrolled_window_add_with_viewport’ is deprecated (declared at /usr/include/gtk-3.0/gtk/gtkscrolledwindow.h:110): Use 'gtk_container_add' instead [-Werror=deprecated-declarations]
cc1: all warnings being treated as errors

added uigtk versiondev labels

Evan Huus said:

CCing you Bill, since you've been dealing with most of these.

Bill Meier said:

Fixed in SVN #‍48065 ....

You'll need to disable "warnings as errors" (or not compile with GTK_DISABLE_DEPRECATED ?) until you can build with Gtk 3.8.

oja…@‍oja… said:

Now build fails with

  CC       libgtkui_a-rtp_player.o
rtp_player.c: In function ‘rtp_player_dlg_create’:
rtp_player.c:2367:21: error: value computed is not used [-Werror=unused-value]
rtp_player.c:2367:71: error: expected ‘)’ before ‘;’ token
rtp_player.c:2457:1: error: passing argument 1 of ‘gtk_container_add’ from incompatible pointer type [-Werror]
/usr/include/gtk-3.0/gtk/gtkcontainer.h:112:9: note: expected ‘struct GtkContainer *’ but argument is of type ‘struct GtkWidget *’
rtp_player.c:2457:1: error: too few arguments to function ‘gtk_container_add’
/usr/include/gtk-3.0/gtk/gtkcontainer.h:112:9: note: declared here
rtp_player.c:2457:1: error: expected ‘;’ before ‘}’ token
rtp_player.c:2337:13: error: unused variable ‘label’ [-Werror=unused-variable]
…
cc1: all warnings being treated as errors

Bill Meier said:

Small typo fixed in SVN #‍48067.

The compile error you encountered should now be fixed....

oja…@‍oja… said:

Thanks, builds fine now.

closed