[PATCH] small addition to SCSI dissection (media rotation speed analysis)

This issue was migrated from bug 9030 in our old bug tracker.

Original bug information:

Reporter: Yaniv Kaul
Status: RESOLVED FIXED
Product: Wireshark
Component: GTK+ UI
OS: All
Platform: x86
Version: Git

Attachments:

packet-scsi.c.diff: patch to epan/dissectors/packet-scsi.c
iscsi-inquery.pcap: BDC type (0x1) is not dissected correctly in release, dissected OK in SVN

Yaniv Kaul said:

Created attachment 11363

patch to epan/dissectors/packet-scsi.c

Build Information:

r51313

1. On Windows, I can't get it work on 1.10.1 (SVN Rev 50926) - it does not recognize page code 0xb1 of a SCSI inquiry.
2. On SVN (or on Linux), it does, so I've prepared the following patch to slightly improve the dissection of a specific field that provides the rotational speed of the media.

added enhancement uigtk versiondev labels

Alexis La Goutte said:

Hi,

it is possible to attach a pcap ?

Yaniv Kaul said:

Attaching a small capture. Works well on Linux SVN, doesn't on Windows 1.10.1/Linux 1.10.0.

Yaniv Kaul said:

Created attachment 11366 BDC type (0x1) is not dissected correctly in release, dissected OK in SVN

Anders Broman said:

Patch Committed revision 51330. Dissection works on my top-of-trunk windows build. Probably enhancements has been made since the release of 1.10, enhancements isn't backported. Try a windows development build. Closing as fixed if the problem persist on a development build feel free to reopen. Regards Anders

closed